Make extend_vec_zeroed, insert_vec_zeroed fallible #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
fallible-allocation
branch
from
9ba613a
to
1eb1ca6
Compare
jswrenn
approved these changes
Sep 15, 2024
joshlf
force-pushed
the
fallible-allocation
branch
from
1eb1ca6
to
72289ae
Compare
They now return `AllocError` on allocation failure. `insert_vec_zeroed` still panics if its `position` argument is out-of-bounds. This requires using `Vec::try_reserve`, which is unstable before 1.57.0. Since our MSRV is currently 1.56.0, these functions are now conditionally compiled and only available on 1.57.0 and later. Closes #1653
joshlf
force-pushed
the
fallible-allocation
branch
from
72289ae
to
21d63a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
=======================================
Coverage 88.00% 88.01%
=======================================
Files 16 16
Lines 5801 5805 +4
=======================================
+ Hits 5105 5109 +4
Misses 696 696 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They now return
AllocErroron allocation failure.insert_vec_zeroedstill panics if itspositionargument is out-of-bounds.Closes #1653