Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Unalign ABI guarantees #168

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Clarify Unalign ABI guarantees #168

merged 1 commit into from
Apr 26, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Apr 26, 2023

Closes #164

@joshlf joshlf mentioned this pull request Apr 26, 2023
Closed
@joshlf joshlf requested a review from djkoloski April 26, 2023 21:53
djkoloski
djkoloski previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@djkoloski djkoloski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshlf joshlf merged commit 31e6146 into main Apr 26, 2023
@joshlf joshlf deleted the unalign-abi-guarantee branch April 26, 2023 22:09
joshlf added a commit that referenced this pull request Aug 3, 2023
@joshlf
Clarify Unalign ABI guarantees (#168)
90991b2 
Closes #164
joshlf added a commit that referenced this pull request Aug 3, 2023
@joshlf
Clarify Unalign ABI guarantees (#168)
9435c4e 
Closes #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djkoloski djkoloski djkoloski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unalign ABI promises are wrong
2 participants
@joshlf @djkoloski