Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[byteorder] Remove byteorder feature and crate dep #583

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[byteorder] Remove byteorder feature and crate dep #583

merged 1 commit into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. [byteorder] Remove byteorder feature and crate dep 

    Remove the `byteorder` feature and the dependency on the `byteorder`
crate. Replace the `ByteOrder` trait and types which implement it from
the `byteorder` crate with our own native implementations.

This prepares us for a future commit in which we will make some of our
functions and methods `const`. This commit doesn't implement this yet
because it doesn't play nicely with our current MSRV; in order to
support this, we'll need to introduce machinery that allows us to
compile functions as conditionally `const` depending on what Rust
toolchain version is used. See #574 for a prototype of this machinery.

Add `Usize` and `Isize` byte order-aware types.

Closes #438
    @joshlf
    joshlf committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e22f7d8 View commit details
    Browse the repository at this point in the history