Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call MobileAds.initialize on background thread #1172

Closed
wants to merge 0 commits into from

Conversation

alihassan143
Copy link

Description

This PR changes the initialization of the Android MobileAds SDK to run on a background thread. This is recommended by the Google Ads team to reduce ANRs. See https://ads-developers.googleblog.com/2024/07/reduce-anrs-when-implementing-mobile-ads.html

Related Issues

*#1135

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Collaborator

@LTPhantom LTPhantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your Pull Request. Unfortunately, it seems there are some format problems before any other check can be run.

@alihassan143
Copy link
Author

@LTPhantom
dart pub global run flutter_plugin_tools format
after that now code is formatted

@alihassan143
Copy link
Author

@LTPhantom kindly allow workflow to run

@alihassan143
Copy link
Author

@LTPhantom all test passed kindly review the pr

@malandr2
Copy link
Collaborator

There is more to this PR than just calling MobileAds.initialize on the background thread, such as adding the OPTIMIZE_AD_LOADING flag to our samples. Those are unrelated changes, can you please remove all extra changes except for the code change in FlutterMobileAdsWrapper.java?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants