Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require phpdocumentor/reflection-docblock in composer.json. Fixes #168 #169

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Require phpdocumentor/reflection-docblock in composer.json. Fixes #168 #169

merged 1 commit into from
Sep 22, 2016

Conversation

shakaran
Copy link
Contributor

Dependency needed for class AdWordsNormalize

@fiboknacky
Copy link
Member

Hi shakaran,

Thanks for the pull request but we already prepared this change internally.
It will be released soon.

Best,
Thanet, AdWords API Team

@fiboknacky fiboknacky closed this Sep 22, 2016
@fiboknacky fiboknacky reopened this Sep 22, 2016
@fiboknacky
Copy link
Member

Hi shakaran,

Sorry for confusion.
As it's a trivial change, I'll merge your change with ours.
Thanks for contribution.

Best,
Knack

@fiboknacky fiboknacky merged commit 06dcb47 into googleads:experimental Sep 22, 2016
@shakaran shakaran deleted the patch-1 branch September 23, 2016 02:23
@shakaran
Copy link
Contributor Author

@fiboknacky thanks ;) When you release it, the issue #168 probably could be closed as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fiboknacky fiboknacky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakaran @fiboknacky