Uniform the use of PHP array short syntax in all files

[shakaran]

Since there are a mix of array() and [], I think that it is a good idea uniform the use for readability issues (also test folder and examples folder are using only short syntax, only remaning the src folder).

Also now that experimental branch is consider as stable we can safely ignore old php versions (lower than 5.4) and officially deprecated the use of old PHP versions (which are EOL and unsupported too) for the sake of new php versions adoptions.

[shakaran]

@vtsao any update or comment regarding to merge this PR? I was expecting almost a quick merge, since changes are trivial

[vtsao]

Hi @shakaran thanks for your PR. The src files marked with "This file was generated from WSDL. DO NOT EDIT." are generated with an internal tool that we need to fix on our end, so any manual changes made to those src files would be overridden the next time we generate.

All other files in your PR should be fine, so if you remove all the generated files I'll review your PR. Thanks.

[shakaran]

@vtsao it seems that all the files under src and my purposed files in the PR has "This file was generated from WSDL. DO NOT EDIT.". So if you will overwrite all, I cannot make anything in my end. It should be fixed in your internal tool. Is the WDSL converter tool publicly available to use?, so I can try to modify that in other PR

[shakaran]

Also FYI, I am using an automatic tool for perfom this called "php-cs-fixer" (it could be installed through composer).

I execute like:

php vendor/friendsofphp/php-cs-fixer/php-cs-fixer fix src/

And using a config file .php_cs like:

<?php

return PhpCsFixer\Config::create()
	->setRiskyAllowed(true)
	->setRules(array(
		'array_syntax' => array('syntax' => 'short'),
	))
	->setFinder(
		PhpCsFixer\Finder::create()
		->exclude('vendor')
			->exclude('tests/Fixtures')
			->in(__DIR__)
	)
;

[vtsao]

I think you had some files like AdWordsNormalizer.php in your PR that are not generated from WSDLs.

Unfortunately our WSDL converter is not public, but I'll track it internally, although it will be a lower priority since it's the generated stub code and the issue is mainly stylistic. Agreed it should be fixed though. Thanks.

[vtsao]

Hi @shakaran do you want to continue this pull request based on my last reply? Otherwise, I'll close it. Thanks.

[shakaran]

@vtsao yes, I will update with the files that you mention. Give me 24-48h to do it

[vtsao]

Sure no rush, just double checking. Thanks!

[shakaran]

@vtsao any update on this PR?