Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend symfony/serializer dep to include version used in symfony 2.8 LTS #217

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

nosnickid
Copy link
Contributor

Symfony 2.8 is in LTS until 2019 ( http://symfony.com/doc/current/contributing/community/releases.html#schedule ), and projects based on it cannot use googleads-php-lib due to a dependency conflict.

This change permits the version included in 2.8. Unit tests pass with this version, and they seem to rely heavily on the serializer.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nosnickid
Copy link
Contributor Author

nosnickid commented Jan 13, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

@nosnickid
Copy link
Contributor Author

And, anecdotally speaking, this has worked fine for me in my afternoon's development on various AdGroup, Label, Campaign and BatchJob integrations.

@vtsao
Copy link
Contributor

vtsao commented Jan 13, 2017

@nosnickid thanks for the PR and the update on testing this.

@fiboknacky can you do some more testing to ensure that ^2.8.0 of the serializer works with our lib before we accept this PR? It would be good to look at the breaking changes for the changelog of ^3.0.0 and see if anything affects us as well.

@fiboknacky
Copy link
Member

It seems there are no breaking changes between ^2.8 and ^3.0 and both versions are pretty much the same.
I also tested with 2.8 real code and all related examples could be run. Unit tests also passed.
So, it makes sense to accept this pull request.

Thanks @nosnickid very much for the PR. :-)

@fiboknacky fiboknacky merged commit d917c36 into googleads:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants