Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On python 2.7.10, filtered log messages raise TypeError: not enough arguments for format string #313

Closed
grzes opened this issue Aug 7, 2018 · 1 comment
Assignees
Labels

Comments

@grzes
Copy link

grzes commented Aug 7, 2018

'appending parent:\n%s\ncontent:\n%s' % (parent, content), works, but:
'appending parent:\n%s\ncontent:\n%s' % list((parent, content)) fails with a TypeError.

Some of googleads built in LogFilters (_SudsMXCoreFilter and _SudsMXLiteralFilter) convert the log record.args from tuple to list resulting in errors.

grzes added a commit to grzes/googleads-python-lib that referenced this issue Aug 7, 2018
@msaniscalchi msaniscalchi self-assigned this Aug 7, 2018
@msaniscalchi
Copy link
Contributor

Hello,

Thanks for the report and PR! I've been able to reproduce this issue. Due to how our development cycle works, I intend to have this merged and integrated on our side by the next Google Ads release.

Regards,
Mark

grzes added a commit to grzes/googleads-python-lib that referenced this issue Aug 7, 2018
@christopherseeley christopherseeley closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants