Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Lighthouse v7 #249

Merged
merged 14 commits into from
Dec 29, 2020
Merged

Update to Lighthouse v7 #249

merged 14 commits into from
Dec 29, 2020

Conversation

warrengm
Copy link
Contributor

@warrengm warrengm commented Dec 21, 2020 •
edited
Loading

Requires some changes to

  • Our config now extends lighthouse:default since lighthouse:full is now deprecated
  • Satisfy the new TS version. In particular:
    • add a nullability check
    • remove a usage of delete on a non-nullable property
    • Add request method shells to satisfy the compiler. These are added at runtime but the compiler can't detect that.
  • Fix tests.
  • Formatting to fix new lint issues that popped up
  • Use node v12 on Travis

@google-cla google-cla bot added the cla: yes CLA has been signed label Dec 21, 2020
@warrengm warrengm marked this pull request as ready for review December 22, 2020 17:36
@warrengm warrengm added the v1.4 PRs and issues for the v1.4 release label Dec 22, 2020
@warrengm warrengm merged commit 471c23c into googleads:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avparmar avparmar avparmar approved these changes

@jburger424 jburger424 Awaiting requested review from jburger424

Assignees
No one assigned
Labels
cla: yes CLA has been signed v1.4 PRs and issues for the v1.4 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warrengm @avparmar