Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

switch to using @google-cloud/common #190

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

ofrobots
Copy link
Contributor

This PR starts using the authorized / retry request flow from the
@google-cloud/common library. From an operational perspective This
shouldn't change behaviour significantly – although there are small
differences in how the new library does retries or how it prioritizes
different sources of the projectId & credentials (environment vs.
metadata vs. config).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2016
Copy link
Contributor

@matthewloring matthewloring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we may need to face the grpc x v7 issues ☹️


var request = require('request');
module.exports = function(options, callback) {
request(options, function(err, response, body) {

This comment was marked as spam.

@ofrobots
Copy link
Contributor Author

Travis fix: #191

Copy link
Contributor

@matthewloring matthewloring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will still need to switch the logger before dropping the dependency on diagnostics-common. googleapis/google-cloud-node#1876 has landed and should release soon.

@ofrobots
Copy link
Contributor Author

We also need googleapis/google-cloud-node#1879 to be able to drop the dependency on diagnostics-common.

@ofrobots
Copy link
Contributor Author

Further, even though this isn't a blocker for development, before we release we would want a resolution on googleapis/google-cloud-node#1822.

ofrobots added a commit that referenced this pull request Dec 15, 2016
grpc is not supported with Node 7 on Windows at the moment. Stop building in that config for now. See #190 for more context.
This PR starts using the authorized / retry request flow from the
@google-cloud/common library. From an operational perspective This
shouldn't change behaviour significantly – although there are small
differences in how the new library does retries or how it prioritizes
different sources of the projectId & credentials (environment vs.
metadata vs. config).
@ofrobots ofrobots merged commit c5d3d22 into googleapis:master Dec 15, 2016
@ofrobots ofrobots deleted the gcloud-common-2 branch December 15, 2016 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants