-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we may need to face the grpc x v7 issues
|
||
var request = require('request'); | ||
module.exports = function(options, callback) { | ||
request(options, function(err, response, body) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Travis fix: #191 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will still need to switch the logger before dropping the dependency on diagnostics-common. googleapis/google-cloud-node#1876 has landed and should release soon.
We also need googleapis/google-cloud-node#1879 to be able to drop the dependency on diagnostics-common. |
Further, even though this isn't a blocker for development, before we release we would want a resolution on googleapis/google-cloud-node#1822. |
grpc is not supported with Node 7 on Windows at the moment. Stop building in that config for now. See #190 for more context.
This PR starts using the authorized / retry request flow from the @google-cloud/common library. From an operational perspective This shouldn't change behaviour significantly – although there are small differences in how the new library does retries or how it prioritizes different sources of the projectId & credentials (environment vs. metadata vs. config).
2d15078
to
ba52554
Compare
This PR starts using the authorized / retry request flow from the
@google-cloud/common library. From an operational perspective This
shouldn't change behaviour significantly – although there are small
differences in how the new library does retries or how it prioritizes
different sources of the projectId & credentials (environment vs.
metadata vs. config).