Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix: correct column numbers for line-1 breakpoints #751

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Aug 20, 2019

Fixes #737

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2019
@kjin kjin marked this pull request as ready for review August 21, 2019 21:40
@kjin kjin requested a review from a team August 21, 2019 21:41
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #751 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   85.45%   85.66%   +0.21%     
==========================================
  Files          13       13              
  Lines         949      949              
  Branches      193      193              
==========================================
+ Hits          811      813       +2     
+ Misses         76       75       -1     
+ Partials       62       61       -1
Impacted Files Coverage Δ
src/agent/state/inspector-state.ts 89.8% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7143525...c3957df. Read the comment docs.

@kjin kjin merged commit f6d4f76 into googleapis:master Aug 21, 2019
*/
const USE_MODULE_PREFIX = utils.satisfies(
process.version,
'<10.16 || >=11 <11.11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did see that v8-to-istanbul was mentioned in the Node PR that made this change, though I didn't realize it was your library 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line 1 breakpoint locations may no longer be accurate after 10.16+
4 participants