-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add error_details definitions #87
Conversation
Add js & type definitions generated from error_details.proto. Fixes: googleapis#77
This doesn't fix #77 alone, right? I expect we should also start using the type defs. Or am I commenting against unfinished work? Apologies if so. |
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 6 6
Lines 348 348
Branches 56 56
=======================================
Hits 337 337
Misses 11 11 Continue to review full report at Codecov.
|
Ah, OK. I'm fine with either too. |
@nolanmar511 As discussed, take these changes and make the definitions actually used, as a separate PR. This one will be closed then. |
I would like to close this PR at this point. It would be fairly easy to get back the definitions, and the issue #77 remains open to track the work needed. If this is a mistake, go ahead and reopen. |
DO NOT LAND YETAdd js & type definitions generated from error_details.proto.
Fixes: #77