Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add error_details definitions #87

Closed
wants to merge 2 commits into from

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Nov 30, 2017

DO NOT LAND YET

Add js & type definitions generated from error_details.proto.

Fixes: #77

Add js & type definitions generated from error_details.proto.

Fixes: googleapis#77
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2017
@aalexand
Copy link
Contributor

aalexand commented Nov 30, 2017

This doesn't fix #77 alone, right? I expect we should also start using the type defs. Or am I commenting against unfinished work? Apologies if so.

@ofrobots
Copy link
Contributor Author

Well, since #75 hasn't landed yet, we could either consider this to 'fix' #77, and adjust #75, or wait for #75 to land and address the issue here.

I would be okay with either.

@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files           6        6           
  Lines         348      348           
  Branches       56       56           
=======================================
  Hits          337      337           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3622e...39cdcfe. Read the comment docs.

@aalexand
Copy link
Contributor

Ah, OK. I'm fine with either too.

@aalexand
Copy link
Contributor

aalexand commented Jan 9, 2018

@nolanmar511 As discussed, take these changes and make the definitions actually used, as a separate PR. This one will be closed then.

@ofrobots
Copy link
Contributor Author

I would like to close this PR at this point. It would be fairly easy to get back the definitions, and the issue #77 remains open to track the work needed.

If this is a mistake, go ahead and reopen.

@ofrobots ofrobots closed this Feb 16, 2018
@ofrobots ofrobots deleted the error-details branch February 16, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants