Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base transports w/ 'operations_client' have incorrect typing #1028

Closed
tseaver opened this issue Oct 13, 2021 · 0 comments
Closed

Base transports w/ 'operations_client' have incorrect typing #1028

tseaver opened this issue Oct 13, 2021 · 0 comments
Assignees
@tseaver
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 13, 2021

From mypy:

google/cloud/datastore_admin_v1/services/datastore_admin/transports/grpc_asyncio.py:297: error: Return type "OperationsAsyncClient" of "operations_client" incompatible with return type "OperationsClient" in supertype "DatastoreAdminTransport"

The sync / async operations client types share no common base class (beyond object). The base transport shouldn't declare any typing at all.
@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 13, 2021
@tseaver tseaver self-assigned this Oct 13, 2021
tseaver added a commit that referenced this issue Oct 13, 2021
@tseaver
fix: remove typing from base transport 'operations_client'
85a26b9 
Closes #1028.
tseaver added a commit that referenced this issue Oct 13, 2021
@tseaver
fix: remove typing from base transport 'operations_client'
8dafd46 
Closes #1028.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tseaver