Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showcase tests to replace handwritten system tests #1771

Open
parthea opened this issue Sep 15, 2023 · 0 comments
Open

Add showcase tests to replace handwritten system tests #1771

parthea opened this issue Sep 15, 2023 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@parthea
Copy link
Contributor

parthea commented Sep 15, 2023

The following handwritten system tests exist for autogenerated clients should be deleted in favor of running system tests closer to where the development occurs:

Simple smoke tests:

More comprehensive tests:

We should evaluate whether to modify these tests so they can be run with gapic-showcase

parthea added a commit to googleapis/python-compute that referenced this issue Sep 15, 2023
The system tests being deleted are handwritten but they are for a client which is fully autogenerated. Issue googleapis/gapic-generator-python#1771 has been filed to evaluate whether these tests can be migrated to `gapic-showcase`, which is closest to where the actual development occurs.
parthea added a commit to googleapis/python-dlp that referenced this issue Sep 15, 2023
The system tests being deleted are handwritten but they are for a client which is fully autogenerated. Issue googleapis/gapic-generator-python#1771 has been filed to evaluate whether these tests can be migrated to `gapic-showcase`, which is closest to where the actual development occurs. We need to delete these tests as it is blocking the migration to `google-cloud-python`, where we are trying to minimize handwritten code.
@parthea parthea added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 15, 2023
parthea added a commit to googleapis/python-os-config that referenced this issue Sep 15, 2023
The system tests being deleted are handwritten but they are for a client which is fully autogenerated. Issue googleapis/gapic-generator-python#1771 has been filed to evaluate whether these tests can be migrated to` gapic-showcase`, which is closest to where the actual development occurs. We need to delete these tests as it is blocking the migration to `google-cloud-python`, where we are trying to minimize handwritten code.
parthea added a commit to googleapis/python-texttospeech that referenced this issue Sep 15, 2023
The system tests being deleted are handwritten but they are for a client which is fully autogenerated. Issue googleapis/gapic-generator-python#1771 has been filed to evaluate whether these tests can be migrated to `gapic-showcase`, which is closest to where the actual development occurs. We need to delete these tests as it is blocking the migration to `google-cloud-python`, where we are trying to minimize handwritten code.
parthea added a commit to googleapis/python-videointelligence that referenced this issue Sep 15, 2023
The system tests being deleted are handwritten but they are for a client which is fully autogenerated. Issue googleapis/gapic-generator-python#1771 has been filed to evaluate whether these tests can be migrated to `gapic-showcase`, which is closest to where the actual development occurs. We need to delete these tests as it is blocking the migration to `google-cloud-python`, where we are trying to minimize handwritten code.
@parthea parthea changed the title Add showcase tests to replace handwritten system tests which will be deleted Add showcase tests to replace handwritten system tests Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant