-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NameError: name 'operation' is not defined #610
Comments
Bumping priority due to impact to product launch |
Dov, can you please take a look? Thanks! |
On it. |
👋 I had a chat with @dizcology and AI Platform will likely have to use an older version of this generator for the time being b/c of other concerns. It it is alright to drop the priority on this since they already have a synth replace fix they wrote for the alpha. |
I've got a fix I'm just about to post review, but it looks like there are other unit tests that are failing too. |
Some APIs define their own module named 'operation' that naively clashes with google.api_core.operation. Both modules are imported with a disambiguating alias, but the alias was not always referenced for the api_core submodule. This change fixes that issue. Fix for googleapis#610
Some APIs define their own module named 'operation' that naively clashes with google.api_core.operation. Both modules are imported with a disambiguating alias, but the alias was not always referenced for the api_core submodule. This change fixes that issue. Fix for #610
Fixed by #615 |
I'm seeing generated test fails on 0.33.4 for a new library
google/cloud/aiplatform
The problem seems to be that
google.api_core.operation
is imported asga_operation
but the client references it asoperation
later on.The API appears to have it's own
operation
type (from google.cloud.aiplatform_v1beta1.types import operation as gca_operation
) which may be causing the conflict.The text was updated successfully, but these errors were encountered: