fix: operation module is properly aliased if necessary #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some APIs define their own module named 'operation' that naively clashes with google.api_core.operation. Both modules are imported with a disambiguating alias, but the alias was not always referenced for the api_core submodule. This change fixes that issue. Fix for googleapis#610
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Sep 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1525 1525
Branches 309 309
=========================================
Hits 1525 1525 Continue to review full report at Codecov.
|
This was referenced Sep 22, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some APIs define their own module named 'operation' that naively
clashes with google.api_core.operation.
Both modules are imported with a disambiguating alias, but the alias
was not always referenced for the api_core submodule.
This change fixes that issue. Fix for #610