feat: file_level and indirectly used resources generate helper methods #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File level resources are defined as options for the proto file, not
for a message type.
Indirectly used resources are resources backed by a message type, but
the message type is not a field type referenced by a service.
E.g.
message Squid {
option (google.api.resource) = {
type: "animalia.mollusca.com/Squid"
pattern: "zones/{zone}/squids/{squid}"
};
}
message CreateSquidRequest{
string name = 1 [
(google.api.resource_reference) = {
type: "animalia.mollusca.com/Squid"
}
];
}
message CreateSquidResponse{}
Both file level and indirectly used resources generate helper methods
in service clients that need them.
Closes googleapis#637
software-dov
requested review from
lukesneeringer,
crwilcox,
vchudnov-g and
busunkim96
google-cla
bot
added
the
cla: yes
software-dov
force-pushed
the
file-level-resources
branch
from
f00d2f4
to
f88fc4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1538 1562 +24
Branches 310 316 +6
=========================================
+ Hits 1538 1562 +24
Continue to review full report at Codecov.
|
busunkim96
approved these changes
Oct 9, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File level resources are defined as options for the proto file, not
for a message type.
Indirectly used resources are resources backed by a message type, but
the message type is not a field type referenced by a service.
E.g.
Both file level and indirectly used resources generate helper methods
in service clients that need them.
Closes #637