Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'from_service_account_info' factory to clients #706

Merged

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 10, 2020

Closes #705

@tseaver tseaver requested a review from a team as a code owner December 10, 2020 18:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #706 (b94686a) into master (f02a125) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #706   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1598      1598           
  Branches       324       324           
=========================================
  Hits          1598      1598           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02a125...b94686a. Read the comment docs.

@software-dov software-dov added the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 94d5f0c into master Dec 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 16, 2020
@tseaver tseaver deleted the 705-add-from_service_account_info-client-factory branch October 13, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'from_service_account_info' classmethod factory to clients.
2 participants