-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: also add the async client to __all__ #869
Conversation
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1694 +86
Branches 328 347 +19
=========================================
+ Hits 1608 1694 +86
Continue to review full report at Codecov.
|
@@ -145,7 +145,7 @@ with open({{ attr.input_parameter }}, "rb") as f: | |||
{% macro render_client_setup(module_name, client_name) %} | |||
# Create a client | |||
client = {{ module_name }}.{{ client_name }}() | |||
{% endmacro %}} | |||
{% endmacro %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated fix to the template file.
Follow up to #859
Closes #815
Also delete a stray } in feature_fragments which was resulting in almost empty files getting generated in clients. https://github.com/googleapis/googleapis-gen/blob/master/google/appengine/v1/google-cloud-appengine-v1-py/examples/feature_fragments