Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for context manager in client #987

Merged
merged 15 commits into from
Oct 4, 2021
Merged
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,18 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
"""
return self._transport

def __enter__(self):
self.transport.__enter__()
return self

def __exit__(self, type, value, traceback):
"""Releases underlying transport's resources.

WARNING: ONLY use as a context manager if the transport is NOT shared
atulep marked this conversation as resolved.
Show resolved Hide resolved
with other clients! Exiting the with block will CLOSE the transport
and may cause errors in other clients!
"""
return self.transport.__exit__(type, value, traceback)

{% for message in service.resource_messages|sort(attribute="resource_type") %}
@staticmethod
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ class {{ service.name }}Transport(metaclass=abc.ABCMeta):
{% endfor %} {# precomputed wrappers loop #}
}

def __enter__(self):
raise NotImplementedError()

def __exit__(self, type, value, traceback):
raise NotImplementedError()

{% if service.has_lro %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,14 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
**kwargs
)

def __enter__(self):
return self

def __exit__(self, type, value, traceback):
"""Closes underlying gRPC channel.
"""
self.grpc_channel.close()

@property
def grpc_channel(self) -> grpc.Channel:
"""Return the channel designed to connect to this service.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,11 @@ def test_{{ service.name|snake_case }}_base_transport():
with pytest.raises(NotImplementedError):
getattr(transport, method)(request=object())

with pytest.raises(NotImplementedError):
transport.__enter__()
atulep marked this conversation as resolved.
Show resolved Hide resolved
with pytest.raises(NotImplementedError):
transport.__exit__(None, None, None)

{% if service.has_lro %}
# Additionally, the LRO client (a property) should
# also raise NotImplementedError
Expand Down Expand Up @@ -903,5 +908,28 @@ def test_client_withDEFAULT_CLIENT_INFO():
)
prep.assert_called_once_with(client_info)

def test_grpc_transport_enter_exit():
client = {{ service.client_name }}(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
with mock.patch.object(type(client.transport._grpc_channel), 'close') as chan_close:
with client as _:
atulep marked this conversation as resolved.
Show resolved Hide resolved
chan_close.assert_not_called()
chan_close.assert_called_once()

def test_grpc_client_enter_exit():
client = {{ service.client_name }}(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
# Test client calls underlying transport.
with mock.patch.object(type(client.transport), "__enter__") as enter:
with mock.patch.object(type(client.transport), "__exit__") as exit:
enter.assert_not_called()
exit.assert_not_called()
with client as _:
atulep marked this conversation as resolved.
Show resolved Hide resolved
enter.assert_called_once()
exit.assert_called()

{% endblock %}
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,9 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
def __exit__(self, type, value, traceback):
atulep marked this conversation as resolved.
Show resolved Hide resolved
"""Releases underlying transport's resources.

WARNING: This makes the transport unusable.
WARNING: ONLY use as a context manager if the transport is NOT shared
with other clients! Exiting the with block will CLOSE the transport
and may cause errors in other clients!
"""
return self.transport.__exit__(type, value, traceback)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1508,6 +1508,11 @@ def test_{{ service.name|snake_case }}_base_transport():
with pytest.raises(NotImplementedError):
getattr(transport, method)(request=object())

with pytest.raises(NotImplementedError):
transport.__enter__()
with pytest.raises(NotImplementedError):
transport.__exit__(None, None, None)

{% if service.has_lro %}
# Additionally, the LRO client (a property) should
# also raise NotImplementedError
Expand Down Expand Up @@ -2459,4 +2464,56 @@ async def test_test_iam_permissions_from_dict_async():

{% endif %}

{% if 'grpc' in opts.transport %}
def test_grpc_transport_enter_exit():
client = {{ service.client_name }}(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
with mock.patch.object(type(client.transport._grpc_channel), 'close') as chan_close:
with client as _:
chan_close.assert_not_called()
chan_close.assert_called_once()

def test_grpc_client_enter_exit():
client = {{ service.client_name }}(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
# Test client calls underlying transport.
with mock.patch.object(type(client.transport), "__enter__") as enter:
with mock.patch.object(type(client.transport), "__exit__") as exit:
enter.assert_not_called()
exit.assert_not_called()
with client as _:
enter.assert_called_once()
exit.assert_called()
{% endif %}

{% if 'rest' in opts.transport %}
def test_rest_transport_enter_exit():
client = {{ service.client_name }}(
credentials=ga_credentials.AnonymousCredentials(),
transport='rest',
atulep marked this conversation as resolved.
Show resolved Hide resolved
)
with mock.patch.object(type(client.transport._session), 'close') as sess_close:
with client as _:
sess_close.assert_not_called()
sess_close.assert_called_once()

def test_rest_client_enter_exit():
client = {{ service.client_name }}(
credentials=ga_credentials.AnonymousCredentials(),
transport='rest',
)
# Test client calls underlying transport.
with mock.patch.object(type(client.transport), "__enter__") as enter:
with mock.patch.object(type(client.transport), "__exit__") as exit:
enter.assert_not_called()
exit.assert_not_called()
with client as _:
enter.assert_called_once()
exit.assert_called()
{% endif %}

{% endblock %}
Original file line number Diff line number Diff line change
Expand Up @@ -1448,7 +1448,18 @@ def analyze_iam_policy_longrunning(self,
# Done; return the response.
return response

def __enter__(self):
self.transport.__enter__()
return self

def __exit__(self, type, value, traceback):
"""Releases underlying transport's resources.

WARNING: ONLY use as a context manager if the transport is NOT shared
with other clients! Exiting the with block will CLOSE the transport
and may cause errors in other clients!
"""
return self.transport.__exit__(type, value, traceback)



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,12 @@ def _prep_wrapped_messages(self, client_info):
),
}

def __enter__(self):
raise NotImplementedError()

def __exit__(self, type, value, traceback):
raise NotImplementedError()

@property
def operations_client(self) -> operations_v1.OperationsClient:
"""Return the client designed to process long-running operations."""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,14 @@ def grpc_channel(self) -> grpc.Channel:
"""
return self._grpc_channel

def __enter__(self):
return self

def __exit__(self, type, value, traceback):
"""Closes underlying gRPC channel.
"""
self.grpc_channel.close()

@property
def operations_client(self) -> operations_v1.OperationsClient:
"""Create the client designed to process long-running operations.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3550,6 +3550,11 @@ def test_asset_service_base_transport():
with pytest.raises(NotImplementedError):
getattr(transport, method)(request=object())

with pytest.raises(NotImplementedError):
transport.__enter__()
with pytest.raises(NotImplementedError):
transport.__exit__(None, None, None)

# Additionally, the LRO client (a property) should
# also raise NotImplementedError
with pytest.raises(NotImplementedError):
Expand Down Expand Up @@ -4048,3 +4053,28 @@ def test_client_withDEFAULT_CLIENT_INFO():
client_info=client_info,
)
prep.assert_called_once_with(client_info)


def test_grpc_transport_enter_exit():
client = AssetServiceClient(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
with mock.patch.object(type(client.transport._grpc_channel), 'close') as chan_close:
with client as _:
chan_close.assert_not_called()
chan_close.assert_called_once()

def test_grpc_client_enter_exit():
client = AssetServiceClient(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
# Test client calls underlying transport.
with mock.patch.object(type(client.transport), "__enter__") as enter:
with mock.patch.object(type(client.transport), "__exit__") as exit:
enter.assert_not_called()
exit.assert_not_called()
with client as _:
enter.assert_called_once()
exit.assert_called()
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,18 @@ def sign_jwt(self,
# Done; return the response.
return response

def __enter__(self):
self.transport.__enter__()
return self

def __exit__(self, type, value, traceback):
"""Releases underlying transport's resources.

WARNING: ONLY use as a context manager if the transport is NOT shared
with other clients! Exiting the with block will CLOSE the transport
and may cause errors in other clients!
"""
return self.transport.__exit__(type, value, traceback)



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,12 @@ def _prep_wrapped_messages(self, client_info):
),
}

def __enter__(self):
raise NotImplementedError()

def __exit__(self, type, value, traceback):
raise NotImplementedError()

@property
def generate_access_token(self) -> Callable[
[common.GenerateAccessTokenRequest],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,14 @@ def grpc_channel(self) -> grpc.Channel:
"""
return self._grpc_channel

def __enter__(self):
return self

def __exit__(self, type, value, traceback):
"""Closes underlying gRPC channel.
"""
self.grpc_channel.close()

@property
def generate_access_token(self) -> Callable[
[common.GenerateAccessTokenRequest],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1484,6 +1484,11 @@ def test_iam_credentials_base_transport():
with pytest.raises(NotImplementedError):
getattr(transport, method)(request=object())

with pytest.raises(NotImplementedError):
transport.__enter__()
with pytest.raises(NotImplementedError):
transport.__exit__(None, None, None)


@requires_google_auth_gte_1_25_0
def test_iam_credentials_base_transport_with_credentials_file():
Expand Down Expand Up @@ -1928,3 +1933,28 @@ def test_client_withDEFAULT_CLIENT_INFO():
client_info=client_info,
)
prep.assert_called_once_with(client_info)


def test_grpc_transport_enter_exit():
client = IAMCredentialsClient(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
with mock.patch.object(type(client.transport._grpc_channel), 'close') as chan_close:
with client as _:
chan_close.assert_not_called()
chan_close.assert_called_once()

def test_grpc_client_enter_exit():
client = IAMCredentialsClient(
credentials=ga_credentials.AnonymousCredentials(),
transport='grpc',
)
# Test client calls underlying transport.
with mock.patch.object(type(client.transport), "__enter__") as enter:
with mock.patch.object(type(client.transport), "__exit__") as exit:
enter.assert_not_called()
exit.assert_not_called()
with client as _:
enter.assert_called_once()
exit.assert_called()
Original file line number Diff line number Diff line change
Expand Up @@ -2179,7 +2179,18 @@ def update_cmek_settings(self,
# Done; return the response.
return response

def __enter__(self):
self.transport.__enter__()
return self

def __exit__(self, type, value, traceback):
"""Releases underlying transport's resources.

WARNING: ONLY use as a context manager if the transport is NOT shared
with other clients! Exiting the with block will CLOSE the transport
and may cause errors in other clients!
"""
return self.transport.__exit__(type, value, traceback)



Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,12 @@ def _prep_wrapped_messages(self, client_info):
),
}

def __enter__(self):
raise NotImplementedError()

def __exit__(self, type, value, traceback):
raise NotImplementedError()

@property
def list_buckets(self) -> Callable[
[logging_config.ListBucketsRequest],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,14 @@ def grpc_channel(self) -> grpc.Channel:
"""
return self._grpc_channel

def __enter__(self):
return self

def __exit__(self, type, value, traceback):
"""Closes underlying gRPC channel.
"""
self.grpc_channel.close()

@property
def list_buckets(self) -> Callable[
[logging_config.ListBucketsRequest],
Expand Down
Loading