Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Separating code gen / package gen for Java #2166

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

garrettjonesgoogle
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #2166 into master will decrease coverage by 0.03%.
The diff coverage is 81.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2166      +/-   ##
============================================
- Coverage     86.83%   86.79%   -0.04%     
- Complexity     5117     5118       +1     
============================================
  Files           454      454              
  Lines         20293    20286       -7     
  Branches       2173     2178       +5     
============================================
- Hits          17622    17608      -14     
- Misses         1905     1907       +2     
- Partials        766      771       +5
Impacted Files Coverage Δ Complexity Δ
.../api/codegen/packagegen/PackagingArtifactType.java 66.66% <33.33%> (-17.95%) 2 <0> (ø)
...oogle/api/codegen/gapic/GapicGeneratorFactory.java 89.61% <90.32%> (-1.42%) 11 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6505c78...d88ad4c. Read the comment docs.

Copy link
Contributor

@andreamlin andreamlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit c3bd98c into googleapis:master Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants