Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Add gcpApiConfigPath to client default options #2231

Merged
merged 5 commits into from
Aug 20, 2018

Conversation

WeiranFang
Copy link
Contributor

Add a new key-value pair 'gcpApiConfigPath' to the client default options. This value will be used by gax-php.
Related PR: googleapis/gax-php#207

@@ -196,6 +196,7 @@ class LibraryServiceGapicClient
'serviceAddress' => self::SERVICE_ADDRESS . ':' . self::DEFAULT_SERVICE_PORT,
'clientConfig' => __DIR__ . '/../resources/library_service_client_config.json',
'descriptorsConfigPath' => __DIR__ . '/../resources/library_service_descriptor_config.php',
'gcpApiConfigPath' => __DIR__ . '/../resources/{@xapiClass.clientConfigName}_grpc_config.json',

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #2231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2231   +/-   ##
=========================================
  Coverage     86.88%   86.88%           
  Complexity     5125     5125           
=========================================
  Files           452      452           
  Lines         20304    20304           
  Branches       2173     2173           
=========================================
  Hits          17641    17641           
  Misses         1893     1893           
  Partials        770      770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78e37e...e743304. Read the comment docs.

@michaelbausor
Copy link
Contributor

Please wait until googleapis/gax-php#207 is ready before merging

@dwsupplee dwsupplee merged commit b0dbe72 into googleapis:master Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants