Skip to content
This repository has been archived by the owner on Mar 20, 2018. It is now read-only.

Remove beta from gRPC imports #126

Closed
bjwatson opened this issue Aug 19, 2016 · 4 comments
Closed

Remove beta from gRPC imports #126

bjwatson opened this issue Aug 19, 2016 · 4 comments
Assignees
Labels

Comments

@bjwatson
Copy link
Contributor

What:

Change imports of grpc.beta... to grpc....

Why:

gRPC is almost GA, and gcloud has already made this change: googleapis/google-cloud-python#2149

@dhermes
Copy link
Contributor

dhermes commented Aug 20, 2016

Thanks for filing @bjwatson. There were a few hairy parts that weren't just renames, e.g. grpc.secure_channel takes ('host:port', channel_creds) while grpc.beta.implementations.secure_channel takes (host, port, channel_credentials) (though the beta implementation calls the stable one).

@geigerj
Copy link
Contributor

geigerj commented Aug 23, 2016

@dhermes Thanks for the heads-up on grpc.secure_channel. From the grpc source code, it looks like all other grpc.beta functions that we currently depend on are currently actually implemented as aliases to their non-beta equivalents, so should be pretty easy.

@dhermes
Copy link
Contributor

dhermes commented Aug 23, 2016

Sure thing. I did a lot of grpc.foo is grpc.beta.foo and was pretty happy to find the same thing

@geigerj
Copy link
Contributor

geigerj commented Aug 24, 2016

Status update: changing GAX requires updating generated code, which itself requires changing our tooling to use grpcio-tools instead of protoc + grpc_python_plugin. That change is waiting on a workaround to grpc/grpc#7857.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants