This repository has been archived by the owner on Jan 26, 2018. It is now read-only.
Allow protoc to be injected #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows packman to support languages like Python, where the official way of doing grpc codegen is through a Python wrapper around protoc.
| @@ -434,7 +440,7 @@ function collectProtoDeps(includePath, protoFile, done) { | |||
| args.push(protoFile); | |||
| // Invokes protoc with --dependency_out to generate the dependency | |||
| // proto files. | |||
| execFile('protoc', args, {}, function(err) { | |||
| execFile(this.protoCompiler, args, {}, function(err) { | |||
There was a problem hiding this comment.
Unfortunately collectProtoDeps is not a method, this. wouldn't work well. Pass it as an argument, or modify the function itself ot a method.
There was a problem hiding this comment.
Good catch. Made it into a method.
- Make a function into a method to reference 'this' correctly - Fix failing tests - Add new tests for new functionality
|
LGTM as long as the test passes. |
Current coverage is 88.78% (diff: 83.33%)@@ master #98 diff @@
==========================================
Files 3 3
Lines 718 722 +4
Methods 150 150
Messages 0 0
Branches 107 110 +3
==========================================
+ Hits 636 641 +5
+ Misses 82 81 -1
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows packman to support languages like Python, where the
official way of doing grpc codegen is through a Python wrapper around
protoc.
Updates googleapis/gax-python#126