This repository has been archived by the owner on Mar 20, 2018. It is now read-only.
Fix error-handling to use new gRPC exceptions #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were catching and wrapping AbortionError, which is no longer used by gRPC. Instead, use RpcError.
Current coverage is 98.02% (diff: 100%)@@ master #131 diff @@
==========================================
Files 8 8
Lines 608 608
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 591 596 +5
+ Misses 17 12 -5
Partials 0 0
|
|
Surprised how easy this fix was! |
geigerj
force-pushed
the
ga-exception
branch
from
2bb75ae
to
dbf531f
Compare
geigerj
force-pushed
the
ga-exception
branch
from
dbf531f
to
69efb57
Compare
bjwatson
suggested changes
Sep 20, 2016
| self.assertEqual(code, grpc.StatusCode.UNKNOWN) | ||
| self.assertEqual(code, grpc.STATUS_CODE_NAMES['UNKNOWN']) | ||
| self.assertIsNone(grpc.exc_to_code(Exception)) | ||
| self.assertIsNone(grpc.exc_to_code(grpc.RpcError())) |
There was a problem hiding this comment.
Should probably also test an RpcError that contains a code.
There was a problem hiding this comment.
It already does: MyError is an RpcError that contains a code (StatusCode.UNKNOWN).
bjwatson
approved these changes
Sep 20, 2016
| self.assertEqual(code, grpc.StatusCode.UNKNOWN) | ||
| self.assertEqual(code, grpc.STATUS_CODE_NAMES['UNKNOWN']) | ||
| self.assertIsNone(grpc.exc_to_code(Exception)) | ||
| self.assertIsNone(grpc.exc_to_code(grpc.RpcError())) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were catching and wrapping AbortionError, which is no
longer used by gRPC. Instead, use RpcError.
/cc @dhermes
Fixes #129 and #130