fix: Error Redactor Case-Insensitive Matching

src/common.ts

@@ -119,15 +119,15 @@
 }
 
 export interface Headers {
   [index: string]: any;
 }
 export type GaxiosPromise<T = any> = Promise<GaxiosResponse<T>>;
 
 export interface GaxiosXMLHttpRequest {
   responseURL: string;
 }
 
 export interface GaxiosResponse<T = any> {
   config: GaxiosOptions;
   data: T;
   status: number;
@@ -149,7 +149,7 @@
    * Optional method to override making the actual HTTP request. Useful
    * for writing tests.
    */
   adapter?: <T = any>(
     options: GaxiosOptions,
     defaultAdapter: (options: GaxiosOptions) => GaxiosPromise<T>
   ) => GaxiosPromise<T>;
@@ -170,8 +170,8 @@
     | 'TRACE'
     | 'PATCH';
   headers?: Headers;
   data?: any;
   body?: any;
   /**
    * The maximum size of the http response content in bytes allowed.
    */
@@ -182,13 +182,13 @@
   maxRedirects?: number;
   follow?: number;
   multipart?: GaxiosMultipartOptions[];
   params?: any;
   paramsSerializer?: (params: {[index: string]: string | number}) => string;
   timeout?: number;
   /**
    * @deprecated ignored
    */
   onUploadProgress?: (progressEvent: any) => void;
   responseType?:
     | 'arraybuffer'
     | 'blob'
@@ -202,7 +202,7 @@
   retry?: boolean;
   // Should be instance of https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal
   // interface. Left as 'any' due to incompatibility between spec and abort-controller.
   signal?: any;
   size?: number;
   /**
    * Implementation of `fetch` to use when making the API call. By default,
@@ -240,7 +240,7 @@
  *
  * @experimental
  */
 export type RedactableGaxiosResponse<T = any> = Pick<
   GaxiosResponse<T>,
   'config' | 'data' | 'headers'
 >;
@@ -369,17 +369,17 @@
 
     for (const key of Object.keys(headers)) {
       // any casing of `Authentication`
-      if (/^authentication$/.test(key)) {
+      if (/^authentication$/i.test(key)) {
         headers[key] = REDACT;
       }
 
       // any casing of `Authorization`
-      if (/^authorization$/.test(key)) {
+      if (/^authorization$/i.test(key)) {
         headers[key] = REDACT;
       }
 
       // anything containing secret, such as 'client secret'
-      if (/secret/.test(key)) {
+      if (/secret/i.test(key)) {
         headers[key] = REDACT;
       }
     }
@@ -394,9 +394,9 @@
       const text = obj[key];
 
       if (
-        /grant_type=/.test(text) ||
-        /assertion=/.test(text) ||
-        /secret/.test(text)
+        /grant_type=/i.test(text) ||
+        /assertion=/i.test(text) ||
+        /secret/i.test(text)
       ) {
         obj[key] = REDACT;
       }

test/test.getch.ts

@@ -26,7 +26,7 @@ import {
   GaxiosResponse,
   GaxiosPromise,
 } from '../src';
-import {GAXIOS_ERROR_SYMBOL} from '../src/common';
+import {GAXIOS_ERROR_SYMBOL, Headers} from '../src/common';
 import {pkg} from '../src/util';
 import qs from 'querystring';
 import fs from 'fs';
@@ -772,8 +772,11 @@ describe('🎏 data handling', () => {
 
     const config: GaxiosOptions = {
       headers: {
-        authentication: 'My Auth',
-        authorization: 'My Auth',
+        Authentication: 'My Auth',
+        /**
+         * Ensure casing is properly handled
+         */
+        AUTHORIZATION: 'My Auth',
         'content-type': 'application/x-www-form-urlencoded',
         random: 'data',
       },
@@ -821,8 +824,8 @@ describe('🎏 data handling', () => {
       assert(e.config.headers);
       assert.deepStrictEqual(e.config.headers, {
         ...config.headers, // non-redactables should be present
-        authentication: REDACT,
-        authorization: REDACT,
+        Authentication: REDACT,
+        AUTHORIZATION: REDACT,
       });
 
       // config redactions - data
@@ -847,11 +850,17 @@ describe('🎏 data handling', () => {
       // response redactions
       assert(e.response);
       assert.deepStrictEqual(e.response.config, e.config);
-      assert.deepStrictEqual(e.response.headers, {
+
+      const expectedHeaders: Headers = {
         ...responseHeaders, // non-redactables should be present
         authentication: REDACT,
         authorization: REDACT,
-      });
+      };
+
+      delete expectedHeaders['AUTHORIZATION'];
+      delete expectedHeaders['Authentication'];
+
+      assert.deepStrictEqual(e.response.headers, expectedHeaders);
       assert.deepStrictEqual(e.response.data, {
         ...response, // non-redactables should be present
         assertion: REDACT,