Update go.sum to remove invalid dependency #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `github.com/golang/lint` has become `golang.org/x/lint`, that dependency causes my build to break with: `go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"` This commit just removes that line from go.sum
googlebot
added
the
cla: yes
jeanbza
added a commit
to jeanbza/go-genproto
that referenced
this pull request
Feb 27, 2019
Updates go.mod to include new version of gRPC, which removes its dependency on the old github.com/golang/lint in favour of the new golang.org/x/lint. Relevant: googleapis#143
Merged
|
Looks like the dependency is coming in through gRPC: I've created #144 to do the needful. |
|
ah thanks, sorry for my incomplete research |
jeanbza
added a commit
that referenced
this pull request
Feb 27, 2019
Updates go.mod to include new version of gRPC, which removes its dependency on the old github.com/golang/lint in favour of the new golang.org/x/lint. Relevant: #143
|
Not a problem at all, thanks for reporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
github.com/golang/linthas becomegolang.org/x/lint, that dependency causes my build to break with:go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"This commit just removes that line from go.sum