Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Placeholder and required attr #1456

Merged
merged 3 commits into from
Jul 24, 2018
Merged

Add Placeholder and required attr #1456

merged 3 commits into from
Jul 24, 2018

Conversation

Assimilationstheorie
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2018
@Assimilationstheorie Assimilationstheorie mentioned this pull request Jun 13, 2018
Closed
@bshaffer bshaffer mentioned this pull request Jun 13, 2018
Closed
@bshaffer
Copy link
Contributor

Would you like to add required to index.php or any other samples?

@Assimilationstheorie
Copy link
Contributor Author

I would add it to all other files, yes.

@Assimilationstheorie
Copy link
Contributor Author

Deal or no deal?

@bshaffer
Copy link
Contributor

Please add the other files to this PR so we encapsulate all the changes in a single commit and pull request!

@bshaffer bshaffer merged commit 123ef5a into googleapis:master Jul 24, 2018
@bshaffer bshaffer mentioned this pull request May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Assimilationstheorie @bshaffer @googlebot