examples: Remove extra setAccessKey call. #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
NanneHuiges
reviewed
Jun 26, 2018
There was a problem hiding this comment.
It looks good to remove this line, but I think I see a second bug: there is no return or exit after the header which is a (second) bug as far as i'm concerned.
While it would probably be bad form to try and patch two bugs in one go, in this situation this second bug means that all code bewow the header is still run, and so the argument
The page is redirected before the $client is ever used.
isn't as clear cut as it looks. I would suggest adding a return (as that seems used in line 28) below the header to make this explicit?
bshaffer
approved these changes
Jun 26, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1162