Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests - expect getStatusCode to return a 200 code #1560

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Fix tests - expect getStatusCode to return a 200 code #1560

merged 2 commits into from
Dec 14, 2018

Conversation

dwsupplee
Copy link
Contributor

A patch in the guzzlehttp/psr7 package now causes exceptions to be thrown when a GuzzleHttp\Psr7\Response object is instantiated without a valid status code.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2018
@dwsupplee dwsupplee merged commit 8213cb8 into googleapis:master Dec 14, 2018
@bshaffer bshaffer mentioned this pull request May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

@tmatsuo tmatsuo Awaiting requested review from tmatsuo

@mattwhisenhunt mattwhisenhunt Awaiting requested review from mattwhisenhunt

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwsupplee @jdpedrie @googlebot