Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete url-shortener.php #1646

Merged
merged 6 commits into from
Jun 7, 2019
Merged

Delete url-shortener.php #1646

merged 6 commits into from
Jun 7, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Jun 4, 2019

The URL Shortener API is deprecated and was shut down March 30, 2019.
https://developers.googleblog.com/2018/03/transitioning-google-url-shortener.html

Please review/merge and mark b/33482850 as fixed.

Requesting review by @bshaffer

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a different API then. The point of this example is to illustrate 3-legged OAuth, and it's the only example we have for that.

Also, the path in examples/index.php needs to be updated

@grant
Copy link
Contributor Author

grant commented Jun 4, 2019

I've updated examples/index.php as mentioned.

To resolve the linked bug, would you like to either:

  • Keep this sample that uses a discontinued API
    or
  • Delete this sample

For showing OAuth, perhaps we can cross link the G Suite samples which use OAuth:
https://github.com/gsuitedevs/php-samples

There are ~12 OAuth samples there.

@dwsupplee
Copy link
Contributor

Is there a third option of updating it to use another service? I only took a quick glance, but it looks like there is only a single insert call.

@bshaffer
Copy link
Contributor

bshaffer commented Jun 4, 2019

More than happy to link to one of the gsuitedevs samples!

@grant
Copy link
Contributor Author

grant commented Jun 4, 2019

I added a link in the examples/ folder to the G Suite samples.

The docs seem to show an example of OAuth with Drive:
https://github.com/googleapis/google-api-php-client#authentication-with-oauth

So I'm not sure exactly why there's the comment of we should be using a different API as Drive already shows OAuth.

@grant
Copy link
Contributor Author

grant commented Jun 7, 2019

@bshaffer Please review.

@bshaffer
Copy link
Contributor

bshaffer commented Jun 7, 2019

@grant tests are failing. Change this line to look for 8 instead of 9.

@grant
Copy link
Contributor Author

grant commented Jun 7, 2019

Done.
That's a super fragile test...

@bshaffer bshaffer merged commit 9b293e9 into googleapis:master Jun 7, 2019
@jdpedrie jdpedrie mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants