tests: Upgrade unit tests for PHP 7.4 compat #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jdpedrie
force-pushed
the
update-tests
branch
from
499132d
to
5c9486c
Compare
derrabus
reviewed
Oct 23, 2019
| @@ -16,7 +16,7 @@ | |||
| "guzzlehttp/psr7": "^1.2" | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "~4.8.36", | |||
| "phpunit/phpunit": "^4.8|^5.0", | |||
There was a problem hiding this comment.
Suggested change
| "phpunit/phpunit": "^4.8|^5.0", | |
| "phpunit/phpunit": "^4.8.36|^5.6", |
We need a PHPUnit version that already has the namespaced TestCase class alias.
|
@google-admin Bump! |
Closed
negoziator
reviewed
Dec 18, 2019
| @@ -24,7 +24,7 @@ php: | |||
| - 7.1 | |||
| - 7.2 | |||
| - 7.3 | |||
| - 7.4snapshot | |||
| - 7.4 | |||
bshaffer
approved these changes
Dec 18, 2019
| } | ||
| public function testRevokeAccessGuzzle5() | ||
| { | ||
| $this->onlyGuzzle5(); |
There was a problem hiding this comment.
Why did you fix the spaces here but not in the other tests? Is it because you realized that arduous task would crush your soul?
FWIW I think this is great, and if we want we can have a follow-up PR for just converting 2 spaces to 4 spaces
There was a problem hiding this comment.
yes, that's a fairly good description of what happened.
jdpedrie
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of PHPUnit, the mocking framework has fairly major compatibility issues with PHP 7.4, and due to (in my opinion) questionable decisions taken by the maintainers to not backport fixes to anyone using less than PHP 7.2, will not be taking action to address this in a way we can make use of.
This change replaces the PHPUnit mocks with prophecy mocks.
Once this PR is tagged by prophecy, we will be able to remove the allow failures tag from PHP 7.4.done.