Support Guzzle7 #1860
Closed
Support Guzzle7 #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Closed
|
@Nyholm out of curiosity, is there a roadmap and target date for Guzzle 8? |
jdpedrie
reviewed
Jun 29, 2020
| "require": { | ||
| "php": ">=5.4", | ||
| "google/auth": "^1.9", | ||
| "google/auth": "dev-guzzle7 as 1.10", |
There was a problem hiding this comment.
need to fix this before merging.
|
Excellent question. I know I’ve turned down many PRs because they would make the upgrade path too complicated from 6 to 7. However since Guzzle 7+ is implementing psr18, then I’m okey with having a bit more complex upgrade path between 7 and 8. I know we need to clear up our messy exceptions inheritance and get rid of a lot of magic functions. |
Co-authored-by: John Pedrie <[email protected]>
Merged
|
added in #1868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a quick search and found a few places where I could fix stuff.
I have not found any other incompatibility issues, but this is not manually tested.
The upgrade from Guzzle 6 to 7 is really smooth. See upgrade docs. But the upgrade to a future Guzzle 8 will not be.
I strongly recommend to move towards PSR-18. Guzzle 7 support PSR-18 out of the box.
Note: #1861
Blocked by googleapis/google-auth-library-php#256