-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release 2.13.1 #2367
Conversation
Can we get an update for this? I am upgrading our PHP webapp to 8.2 version and it broke because of Google Analytics, is there ETA for when this is going to be merged? |
@kaktusas2598 that change only adds PHP 8.2 to the testing matrix. There is nothing in this release that would fix an issue you are having on PHP 8.2 and Google analytics. I suggest updating to the latest version for this library AND it's dependencies (we did fix a bug for PHP 8.2 in the google-api-php-client-services repo) and if you still see the error, please file a new issue here. Thank you! |
@bshaffer Thank you, I did upgrade this package to the latest version - 2.13.0 and now all of our unit tests using GA are broken |
What errors are you seeing? |
@bshaffer Way too many errors to post here, but as an example I have PHPUnit test:
Where $filter is ColumnWhiteListFilter class object
|
@kaktusas2598 i will need to see a specific error on our end in order to address it, as the message you provided could be caused by anything, and unfortunately is not enough information for us to act on. I'd suggest debugging why the argument is NULL. But there's nothing in that error which points to the fault being with this library. |
@bshaffer I think I found the actual error for the test above:
Returns Google\Service\Analytics\Columns object I checked the fixture, and after unserialize() is called, it does look like it's correct, returning object of Google/Service/Analytics/Columns and it does have items in it |
When will 2.14 come out with the support of PHP 8.2? |
559de92
to
7489ab3
Compare
The current release (and ALL previous releases, AFAIK) support PHP 8.2, but they'll throw a deprecation warning. This next release fixes that. |
🤖 I have created a release beep boop
2.13.1 (2023-03-13)
Bug Fixes
This PR was generated with Release Please. See documentation.