Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 2.13.1 #2367

Merged
merged 1 commit into from
Mar 13, 2023
Merged

chore(main): release 2.13.1 #2367

merged 1 commit into from
Mar 13, 2023

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Jan 9, 2023

🤖 I have created a release beep boop

2.13.1 (2023-03-13)

Bug Fixes

  • Allow dynamic properties on model classes (#2408) (11080d5)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team as a code owner January 9, 2023 22:26
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2023
@kaktusas2598
Copy link

Can we get an update for this? I am upgrading our PHP webapp to 8.2 version and it broke because of Google Analytics, is there ETA for when this is going to be merged?

@bshaffer
Copy link
Contributor

bshaffer commented Jan 26, 2023

@kaktusas2598 that change only adds PHP 8.2 to the testing matrix. There is nothing in this release that would fix an issue you are having on PHP 8.2 and Google analytics. I suggest updating to the latest version for this library AND it's dependencies (we did fix a bug for PHP 8.2 in the google-api-php-client-services repo) and if you still see the error, please file a new issue here. Thank you!

@bshaffer bshaffer added the release-please:force-run To run release-please label Jan 27, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Jan 27, 2023
@kaktusas2598
Copy link

@bshaffer Thank you, I did upgrade this package to the latest version - 2.13.0 and now all of our unit tests using GA are broken

@bshaffer
Copy link
Contributor

@bshaffer Thank you, I did upgrade this package to the latest version - 2.13.0 and now all of our unit tests using GA are broken

What errors are you seeing?

@kaktusas2598
Copy link

@bshaffer Way too many errors to post here, but as an example I have PHPUnit test:

public function testFilterColumns() {
        $columns = $this->filter->filterColumns($this->gaColumnsProvider()->getItems());

        $this->assertNotNull($columns);
        $this->assertContainsOnlyInstancesOf('\Google_Service_Analytics_Column', $columns);
        $this->assertEquals(2, count($columns));
    }

Where $filter is ColumnWhiteListFilter class object
and $this->gaColumnsProvider()->getItems() returns example GA columns, test fails with:

"TypeError: Pi\GoogleAnalytics\Model\ColumnWhiteListFilter::filterColumns(): Argument #1 ($columns) must be of type array, null given, called in /srv/www/tests/unit/application/modules/google-analytics/Model/ColumnWhiteListFilterTest.php on line 22 and defined in /srv/www/application/modules/google-analytics/code/Model/ColumnWhiteListFilter.php:27

@bshaffer
Copy link
Contributor

@kaktusas2598 i will need to see a specific error on our end in order to address it, as the message you provided could be caused by anything, and unfortunately is not enough information for us to act on.

I'd suggest debugging why the argument is NULL. But there's nothing in that error which points to the fault being with this library.

@kaktusas2598
Copy link

kaktusas2598 commented Jan 27, 2023

@bshaffer I think I found the actual error for the test above:

$this->gaColumnsProvider()

Returns Google\Service\Analytics\Columns object
and then we use getItems() method, but this method returns NULL.

I checked the fixture, and after unserialize() is called, it does look like it's correct, returning object of Google/Service/Analytics/Columns and it does have items in it

@bulgariamitko
Copy link

When will 2.14 come out with the support of PHP 8.2?

@release-please release-please bot changed the title chore(main): release 2.14.0 chore(main): release 2.13.1 Mar 13, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from 559de92 to 7489ab3 Compare March 13, 2023 20:05
@bshaffer
Copy link
Contributor

When will 2.14 come out with the support of PHP 8.2?

The current release (and ALL previous releases, AFAIK) support PHP 8.2, but they'll throw a deprecation warning. This next release fixes that.

@bshaffer bshaffer merged commit 895749d into main Mar 13, 2023
@bshaffer bshaffer deleted the release-please--branches--main branch March 13, 2023 20:38
@release-please
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: tagged autorelease: triggered kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants