-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 #3
Comments
This is on our radar, but we don't have any concrete plans right now. I'm going to tag this "enhancement" for now, so people don't keep reopening. |
I also need python3 support since I started a project with python3 and now I want google+ sigin and access to google contacts. Here is the google document which lists the google api python client as needed for the g+ signin implementation, see step 8: https://developers.google.com/+/web/signin/server-side-flow It seems that there are two strategies:
It seems that no actual python dependency is listed for either Seeing python3 support as inevitable if a high level path is chosen now then others can start contributing. |
@ianjosephwilson i'm with you that we ultimately want a plan for moving to python 3 -- it also has to include |
@craigcitro I think same trick used in
So I don't think the embedding requirement will be limiting in choosing between strategies 1 and 2 I mentioned earlier. What is the minimum python version that must be supported? |
2.6 is fine for a minimum version. |
Maybe updating each repo in place to work with both python 2.6+ and python 3.2+ would be the best option then, strategy 2. Can a depedency on six be added? It is discussed in the python docs here: https://docs.python.org/3/howto/pyporting.html#projects-to-consider |
There seems to be a python3 compatible unofficial clone: https://github.com/enorvelle/GoogleApiPython3x |
+1 |
wait.. google doesn't support python3? |
Yeah, it's ridiculous
|
its unbelievable. and theres not even concrete plans it seems like... |
dammit, google 👎 |
Hah! From the Python example in their docs:
Not! |
to anyone complaining we didn't already implement this: happy to look at pull requests. @ianjosephwilson we're making good progress on getting oauth2client updated for py3, and it looks like we're going to be able to do it with a single codebase (and no import magic). that's definitely the way i'd like to do it here, too, unless there's a reason i'm not seeing that it won't work. |
+1 here as well. I'm trying to extract data from google docs. |
+1 |
@craigcitro, you mentioned making good progress 3 months ago. Where does py3 support currently stand? No need to duplicate efforts. Is there a py3 branch being worked on? |
oauth2client is now updated for python3. i've done no work on this repo. |
I'm waiting python3 support too. Pull #25 offers the way to migrate python3. |
Just wanted to add that this is the only dependency in my application that doesn't support Python3, so any work done porting this would be much appreciated. |
+1 for Python 3 support. |
1 similar comment
+1 for Python 3 support. |
👍 for python support. I want to start a new project and this is the only dependency that requires Python 2 |
For our particular use case, we're using the Gmail API and also interacting with JIRA behind SSL - this requires SNI, which Python 2.x doesn't support: http://docs.python-requests.org/en/latest/community/faq/#what-are-hostname-doesn-t-match-errors So yes, Python 3.x support would be fantastic for this issue (among all the other good reasons, of course). Is there any update on this yet? |
given that python2 doesn't support SNI and google is planning on dropping all ssl3 support "real soon now", and forcing most (all) connections to be https, it's very important that we (when i say WE, i really mean GOOGLE because the other we -- aka devs, are desperately in need of py3 support for not just SNI, but many other things py2 doesn't support) start supporting python3 as soon as possible across the board. python2 ssl support is rather horrible and shoehorning things like pyopenssl in doesn't really solve problems and creates a lot of code refactoring and dependencies. i'll be very happy to test google facing modules for py3 support. google not supporting python3 pretty much across the board in all their tools, is pretty much the biggest reason i avoid using google tools. any informed people that can explain why google strongly ignores py3? i'm not looking for rumor mongoring or hate bashing, i'm looking for avenues to address the problems. p.s. i use sublimetext3 as well and i would dearly love to hook this up |
I really want to see this happen, is there a branch with Python 3 support in the works? I'm willing to help port the library. @craigcitro |
You can use the trick from this comment: #45 (comment)
And remember to use oauth2client 1.4.2 instead of the newest one. |
FWIW, this looks solid to me across python 2 and python 3. My test suite runs clean. Any idea when we can expect to see this hit PyPI? Tox output
|
Ahh, sorry, my fault! I pip3ed (which worked) without realizing this probably wasn't pushed into PyPi yet. |
Not sure when it will be pushed. I created another PR (#67) to update some |
Python 3 support has now been pushed to PyPI as version 1.4.0 (https://pypi.python.org/pypi/google-api-python-client/1.4.0). Please everyone test away and report defects and mistakes back to us here? |
@methane It looks like that was not yet pushed to PyPI. Latest install 0.9 still broken. Installing from source worked! |
"No Python 3 Support" probably should be up front and center. I spent quite a while trying to figure out why installing with pip3 worked but the Google samples all failed on authorization. It's because clean_headers() that the docs says converts bytes to strings actually converts strings to bytes with Python 3! |
@kylegoetz Read this thread, Python 3 is supported but the package on PyPI isn't updated yet. |
@wldcordeiro Sorry, the issue is still marked as open, so I thought that meant the issue was not resolved. In any case, this repo instructs you to install with pip, and installing with pip downloads a version for Python 2 even if you're using pip for Python 3. So the install instructions are not correct. That's all I was trying to say: should be corrected install instructions. |
Pip3 install from Google works now, if you install httplib2 from master from source first. That library is the one that hasn't yet been pushed to PyPi. I pip3ed the Google API without problems after installing that library. (On my phone, sorry for any typos)
|
Good news! |
🎉😀👍 |
This issue can be closed at this point. |
FYI, I'm having trouble sending e-mails with binary (PDF) attachments when using Python 3.4 (google-api-python-client version 1.4.0 and httplib2 version 0.9.1). Issue filed here. |
This seems to be an overall success; closing this issue. |
This page still says only 2.6 and 2.7 are supported: https://developers.google.com/api-client-library/python/start/installation |
@xenomachina Thanks! Filed an internal bug. |
Bug fixed... the official docs now state 2.6, 2.7, 3.3, and 3.4 are supported. Python 3 users will probably use "pip3" instead of "pip". |
Excellent! ---- Everything happens for a reason. Attitude determines everything! On 7 August, 2015 at 3:11:54 am, wesley chun ([email protected]) wrote: Bug fixed... the official docs now state 2.6, 2.7, 3.3, and 3.4 are supported. Python 3 users will probably use "pip3" instead of "pip". — |
Backward compatibility update (Google/oauth2client)
Request for Python 3 support (continuing on from https://code.google.com/p/google-api-python-client/issues/detail?id=57). My use case is for using the popular editor Sublime Text 3 to interact with the Google API.
The text was updated successfully, but these errors were encountered: