Skip to content

Commit

Permalink
checkers
Browse files Browse the repository at this point in the history
  • Loading branch information
ddelgrosso1 committed Sep 24, 2024
1 parent 6c9e929 commit 965ea79
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 22 deletions.
6 changes: 3 additions & 3 deletions google/cloud/storage/tests/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ load(
":storage_client_integration_tests.bzl",
"storage_client_integration_tests",
)
load (
load(
":storage_client_universe_domain_tests.bzl",
"storage_client_universe_domain_tests",
)
Expand Down Expand Up @@ -72,6 +72,7 @@ VARIATIONS = {
}),
deps = [
"//:common",
"//:experimental-universe_domain",
"//:storage",
"//google/cloud/storage:storage_client_testing",
"//google/cloud/testing_util:google_cloud_cpp_testing_grpc_private",
Expand All @@ -80,6 +81,5 @@ VARIATIONS = {
"//protos/google/cloud/storage/tests:storage_conformance_tests_cc_proto",
"@com_google_absl//absl/strings",
"@com_google_googletest//:gtest_main",
"//:experimental-universe_domain",
],
) for test in storage_client_universe_domain_tests]
) for test in storage_client_universe_domain_tests]
35 changes: 16 additions & 19 deletions google/cloud/storage/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,8 @@ set(storage_client_integration_tests_production
# cmake-format: sort
alternative_endpoint_integration_test.cc key_file_integration_test.cc
signed_url_integration_test.cc unified_credentials_integration_test.cc)
set(storage_client_universe_domain_tests
# cmake-format: sort
universe_domain_integration_test.cc)
set(storage_client_universe_domain_tests # cmake-format: sort
universe_domain_integration_test.cc)
list(APPEND storage_client_integration_tests
${storage_client_integration_tests_production})
list(SORT storage_client_integration_tests)
Expand All @@ -87,9 +86,8 @@ include(CreateBazelConfig)
export_list_to_bazel(
"storage_client_integration_tests.bzl" "storage_client_integration_tests"
"storage_client_integration_tests_production" YEAR "2018")
export_list_to_bazel(
"storage_client_universe_domain_tests.bzl" "storage_client_universe_domain_tests"
YEAR "2024")
export_list_to_bazel("storage_client_universe_domain_tests.bzl"
"storage_client_universe_domain_tests" YEAR "2024")

foreach (fname IN LISTS storage_client_integration_tests)
google_cloud_cpp_add_executable(target "storage" "${fname}")
Expand Down Expand Up @@ -126,23 +124,22 @@ foreach (target IN ITEMS storage_smoke_test_async storage_smoke_test_grpc
LABELS
"integration-test;integration-test-emulator;integration-test-gha")
endforeach ()
foreach(fname IN LISTS storage_client_universe_domain_tests)
foreach (fname IN LISTS storage_client_universe_domain_tests)
google_cloud_cpp_add_executable(target "storage" "${fname}")
target_link_libraries(
${target}
PRIVATE storage_client_testing
google_cloud_cpp_testing
google-cloud-cpp::storage
google-cloud-cpp::common
google-cloud-cpp::universe_domain
GTest::gmock_main
GTest::gmock
GTest::gtest
Threads::Threads
absl::strings
nlohmann_json)
endforeach()

google_cloud_cpp_testing
google-cloud-cpp::storage
google-cloud-cpp::common
google-cloud-cpp::universe_domain
GTest::gmock_main
GTest::gmock
GTest::gtest
Threads::Threads
absl::strings
nlohmann_json)
endforeach ()

# We just know that these tests need to be run against production.
foreach (fname IN LISTS storage_client_integration_tests_production)
Expand Down

0 comments on commit 965ea79

Please sign in to comment.