Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine how best to include universe_domain in cmake builds #13495

Closed
scotthart opened this issue Jan 22, 2024 · 2 comments
Closed

Determine how best to include universe_domain in cmake builds #13495

scotthart opened this issue Jan 22, 2024 · 2 comments
Assignees
@scotthart
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

Currently select builds are manually enabling universe_domain a la:

ENABLED_FEATURES="${ENABLED_FEATURES},universe_domain"

Typically, these are builds that already build the libs the demos depend on.

Figure if there's a better way to do this that doesn't cause build times to skyrocket as multiple large service libs are dependencies.
@scotthart scotthart added the type: cleanup An internal cleanup or hygiene concern. label Jan 22, 2024
@scotthart scotthart self-assigned this Jan 22, 2024
@scotthart scotthart mentioned this issue Jan 23, 2024
Merged
@scotthart
Copy link
Member Author

Scott will look at

@scotthart
Copy link
Member Author

Fixed as part of 13496

@ddelgrosso1 ddelgrosso1 mentioned this issue Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scotthart scotthart

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scotthart