tests(storage): add universe domain integration test #14728
Conversation
product-auto-label
bot
added
the
api: storage
ddelgrosso1
force-pushed
the
ud-storage-test
branch
from
965ea79
to
13d08a4
Compare
ddelgrosso1
temporarily deployed
to
external
GitHub Actions
Inactive
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @ddelgrosso1)
ci/cloudbuild/builds/universe-domain-storage.sh line 29 at r1 (raw file):
if [[ -n "${UD_SA_KEY_FILE}" ]]; then ud::bazel_run //google/cloud/storage/tests:universe_domain_integration_test
As this is a test using gtest infrastructure, I would look at adding a ud::bazel_test, if necessary, or just using bazel test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14728 +/- ##
==========================================
- Coverage 93.42% 93.41% -0.02%
==========================================
Files 2314 2315 +1
Lines 207602 207640 +38
==========================================
+ Hits 193952 193966 +14
- Misses 13650 13674 +24 ☔ View full report in Codecov by Sentry. |
|
Realized I probably need to remove cmake from this due to #13495 |
ddelgrosso1
force-pushed
the
ud-storage-test
branch
from
9a81e01
to
f970c11
Compare
|
Need to get the actual build running in CI. |
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @scotthart)
ci/cloudbuild/builds/universe-domain-storage.sh line 29 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
As this is a test using gtest infrastructure, I would look at adding a
ud::bazel_test, if necessary, or just usingbazel test
Done.
ddelgrosso1
force-pushed
the
ud-storage-test
branch
from
f970c11
to
441836c
Compare
ddelgrosso1
force-pushed
the
ud-storage-test
branch
from
2269b3d
to
e1dfe15
Compare
ddelgrosso1
temporarily deployed
to
external
GitHub Actions
Inactive
ddelgrosso1
force-pushed
the
ud-storage-test
branch
from
1fa95c8
to
05ef21d
Compare
ddelgrosso1
temporarily deployed
to
external
GitHub Actions
Inactive
add and modify builds adding perms checkers skip tests if missing UD vars cleanup checkers use tags to filter test not TEST_SKIP fix testoptions fix testoptions checkers skip test if environment variables missing remove test from cmake build remove module.bazel remove storage specific universe domain build scripts update copyright date create ud:bazel_test to copy environment variables to test env include common bazel args utilize runfiles to read ud_sa_key_file debug code more debug code symlink temp file fix vars remove runfiles remove testing code use run debug use test add sandbox_add_mount_pair to bazel test
ddelgrosso1
force-pushed
the
ud-storage-test
branch
from
1357988
to
5e59155
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, 3 of 4 files at r5, 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @bajajneha27)
This change is