Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rest): too many debug headers #10054

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 17, 2022

We were injecting a :curl-peer pseudo-header (usually used for troubleshooting) for each Read() call. The existing tests did not catch this because this headers were never exposed to the application layer either.


This change is Reviewable

We were injecting a `:curl-peer` pseudo-header (usually used for
troubleshooting) for each `Read()` call.  The existing tests did not
catch this because this headers were never exposed to the application
layer either.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 2ab72971ddc22704b7f11cd6c8eae4dd89b6acf1

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 94.22% // Head: 94.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d778134) compared to base (e90fd34).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10054   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files        1527     1528    +1     
  Lines      141822   141886   +64     
=======================================
+ Hits       133633   133696   +63     
- Misses       8189     8190    +1     
Impacted Files Coverage Δ
google/cloud/internal/curl_http_payload.h 100.00% <ø> (ø)
google/cloud/internal/curl_http_payload.cc 100.00% <100.00%> (ø)
google/cloud/internal/curl_impl.cc 88.18% <100.00%> (-0.03%) ⬇️
...loud/internal/curl_rest_client_integration_test.cc 98.41% <100.00%> (+0.10%) ⬆️
...torage/tests/object_read_large_integration_test.cc 100.00% <100.00%> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.17%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d778134ac3f3b42ddd592e7dc4609e892fd516f6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review October 17, 2022 21:33
@coryan coryan requested a review from a team as a code owner October 17, 2022 21:33
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan enabled auto-merge (squash) October 17, 2022 21:36
@coryan coryan merged commit b4b2977 into googleapis:main Oct 17, 2022
@coryan coryan deleted the fix-rest-e-too-many-headers branch October 17, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants