Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): generate simple samples for *Client #10118

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 28, 2022

This is part of the work for #10114. Future PRs will include these samples in the CI builds, update the scaffold to generate build scripts for them, and inject the samples into the Doxygen landing page. I don't want to create PRs that change a thousand files at a time.


This change is Reviewable

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 28, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4269017ffad3e8b9c8a6f6e5e1155c4d486ab465

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan force-pushed the feat-generator-basic-client-samples-pr2 branch from 4269017 to c2b620c Compare October 28, 2022 18:16
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c2b620ccfd37d43bb67ae89be767571f9d304093

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan force-pushed the feat-generator-basic-client-samples-pr2 branch from c2b620c to 4ad0c34 Compare October 28, 2022 18:18
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4ad0c345f7e832eb2862c30bbb917bdf59439c8e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a48503376b8d7d2a9ac43a4cc1d27d2855540a1d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 93.97% // Head: 93.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a485033) compared to base (c50cb0c).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a485033 differs from pull request most recent head 5b79693. Consider uploading reports for the commit 5b79693 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10118   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files        1515     1517    +2     
  Lines      140003   140021   +18     
=======================================
+ Hits       131566   131593   +27     
+ Misses       8437     8428    -9     
Impacted Files Coverage Δ
generator/generator_test.cc 94.36% <100.00%> (ø)
generator/internal/descriptor_utils.cc 88.46% <100.00%> (+0.08%) ⬆️
generator/internal/sample_generator.cc 100.00% <100.00%> (ø)
generator/internal/sample_generator.h 100.00% <100.00%> (ø)
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (+0.16%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.63% <0.00%> (+0.33%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 98.36% <0.00%> (+0.54%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (+0.56%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 28, 2022 19:44
@coryan coryan requested a review from a team as a code owner October 28, 2022 19:44
generator/CMakeLists.txt Outdated Show resolved Hide resolved
@coryan coryan enabled auto-merge (squash) October 28, 2022 20:28
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: feddfa6983f0c00e0a72009b656a922d5041521f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5b79693c749e315f8557817629c323b93b5c4b83

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit cb5c149 into googleapis:main Oct 28, 2022
@coryan coryan deleted the feat-generator-basic-client-samples-pr2 branch October 28, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants