Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(pubsub): create page for configuration options #10198

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 8, 2022

This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Nov 8, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 85cee61c7f9f56670c82d218350e5ae52c879b77

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 93.98% // Head: 93.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (40f3ae5) compared to base (7b600b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10198   +/-   ##
=======================================
  Coverage   93.98%   93.98%           
=======================================
  Files        1531     1531           
  Lines      141082   141082           
=======================================
+ Hits       132594   132595    +1     
+ Misses       8488     8487    -1     
Impacted Files Coverage Δ
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.81% <0.00%> (-0.55%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.17%) ⬇️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 8, 2022 01:42
@coryan coryan requested a review from a team as a code owner November 8, 2022 01:42
@@ -50,11 +50,13 @@ namespace pubsub {
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN

/// The retry policy
/// @ingroup pubsub-options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional nit: use /** ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

struct RetryPolicyOption {
using Type = std::shared_ptr<pubsub::RetryPolicy>;
};

/// The backoff policy
/// @ingroup pubsub-options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same optional nit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@coryan coryan force-pushed the doc-pubsub-add-options-group branch from 85cee61 to 40f3ae5 Compare November 8, 2022 15:20
@coryan coryan enabled auto-merge (squash) November 8, 2022 15:20
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 40f3ae571f38903938eea1ee520e5f261997e687

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 22ecaf5 into googleapis:main Nov 8, 2022
@coryan coryan deleted the doc-pubsub-add-options-group branch November 8, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants