-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(pubsub): create page for configuration options #10198
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.98% // Head: 93.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10198 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 1531 1531
Lines 141082 141082
=======================================
+ Hits 132594 132595 +1
+ Misses 8488 8487 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
google/cloud/pubsub/options.h
Outdated
@@ -50,11 +50,13 @@ namespace pubsub { | |||
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN | |||
|
|||
/// The retry policy | |||
/// @ingroup pubsub-options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional nit: use /**
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
google/cloud/pubsub/options.h
Outdated
struct RetryPolicyOption { | ||
using Type = std::shared_ptr<pubsub::RetryPolicy>; | ||
}; | ||
|
||
/// The backoff policy | ||
/// @ingroup pubsub-options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same optional nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
85cee61
to
40f3ae5
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
This change is