feat(speech): generate speech v2

[dbolduc]

Fixes #10168

Note that moving speech v1 is not a prerequisite for making this change. The types will not conflict, and we know where we want to put speech v2.

I tried to come up with a general glob solution. It deserves scrutiny.

---

This change is 

[google-cloud-cpp-bot]

Google Cloud Build Logs
For commit: 4535e8b4c49ab62521055674d4fb6fafa7510b35

• Public Access Build Logs
• Cloud Build Console (requires auth)
• Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

[codecov]

Codecov Report

Base: 93.84% // Head: 93.84% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a890aac) compared to base (793faa1).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10228      +/-   ##
==========================================
- Coverage   93.84%   93.84%   -0.01%     
==========================================
  Files        1551     1551              
  Lines      142784   142784              
==========================================
- Hits       134000   133998       -2     
- Misses       8784     8786       +2     

Impacted Files	Coverage Δ
google/cloud/bigtable/async_read_stream_test.cc	97.32% <0.00%> (-0.67%)	⬇️
google/cloud/pubsub/subscriber_connection_test.cc	97.81% <0.00%> (-0.55%)	⬇️
...cloud/pubsub/internal/subscription_session_test.cc	97.98% <0.00%> (-0.17%)	⬇️
...integration_tests/schema_admin_integration_test.cc	100.00% <0.00%> (+1.11%)	⬆️
google/cloud/internal/async_connection_ready.cc	93.61% <0.00%> (+4.25%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[coryan]

I see no changes the main.dox which would include the samples for this new client. I think you will need to make some changes to the ci/generate-markdown scripts and maybe add new placeholders in main.dox.

Likewise, you need a new group for the Options documentation.

Finally, the samples are not getting compiled. You need to add a BUILD and CMakeLists.txt file (the scaffold steps would have done that before). And you need to modify the top-level CMake file around here:

google-cloud-cpp/CMakeLists.txt

Lines 358 to 365 in 1fbb8eb

	if (GOOGLE_CLOUD_CPP_ENABLE_EXAMPLES
	AND IS_DIRECTORY
	"${CMAKE_CURRENT_SOURCE_DIR}/google/cloud/${feature}/samples"
	AND EXISTS
	"${CMAKE_CURRENT_SOURCE_DIR}/google/cloud/${feature}/samples/CMakeLists.txt"
	)
	add_subdirectory(google/cloud/${feature}/samples)
	endif ()

[coryan]

if you are planning to use something like a list, then do so:

set(service_dirs "" "v2/")
set(internal_dirs "" "internal/")
set(extensions "*.h" ".cc")

But all of this seems overly complicated, I think something like

file(GLOB source_files RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}"
       "*.h" "*.cc" "internal/*.h" "intermal/*.cc"
       "v2/*.h" "v2/*.cc" "v2/internal/*.h" "v2/intermal/*.cc")

Is easier to read.

[dbolduc]

Ack, I unrolled the internal_dirs and extensions, but I left the service_dirs loop. I think it offers a general solution that we can use in other libraries. e.g. bigquery might (eventually) look like:

set(service_dirs "analyticshub/v1/" "connection/v1/"
                 "datatransfer/v1/" "migration/v2/"
                 "reservation/v1/" "storage/v1/" "v2/")

[coryan]

This is a new Doxygen group, you need to create a page to host these.

[dbolduc]

Discussed offline. Fixed by #10238 + regeneration

[google-cloud-cpp-bot]

Google Cloud Build Logs
For commit: a890aac96e212c83048ce468db4aed6648a068dd

• Public Access Build Logs
• Cloud Build Console (requires auth)
• Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

[dbolduc]

I see no changes the main.dox which would include the samples for this new client. I think you will need to make some changes to the ci/generate-markdown scripts and maybe add new placeholders in main.dox.

Fixed by #10241 + regeneration

[coryan]

Seems like some sort of sort -u would be useful in the script that updates these things?

[dbolduc]

I lean more towards including the namespace, such as: speech_v2::MakeSpeechConnection()