Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support logging for unified Rest credentials #10412

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 9, 2022

Fixes #10316 and fixes #3429

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 0d4c608bc539aefb036d8d4674124f7f4b701147

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 93.86% // Head: 93.85% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (61c9881) compared to base (f601caa).
Patch coverage: 61.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10412      +/-   ##
==========================================
- Coverage   93.86%   93.85%   -0.01%     
==========================================
  Files        1610     1610              
  Lines      145810   145821      +11     
==========================================
- Hits       136860   136859       -1     
- Misses       8950     8962      +12     
Impacted Files Coverage Δ
...cloud/storage/internal/unified_rest_credentials.cc 72.22% <33.33%> (-1.37%) ⬇️
google/cloud/internal/unified_rest_credentials.cc 73.58% <57.14%> (-1.42%) ⬇️
...ogle/cloud/internal/oauth2_decorate_credentials.cc 80.00% <75.00%> (-20.00%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.29% <0.00%> (-0.67%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.99% <0.00%> (-0.67%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
google/cloud/internal/credentials_impl.h 100.00% <0.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 100.00% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 9, 2022 15:42
@coryan coryan requested a review from a team as a code owner December 9, 2022 15:42
std::shared_ptr<oauth2_internal::Credentials> Decorate(
std::shared_ptr<oauth2_internal::Credentials> impl, Options const& opts);

/// Add only a logging decorator to the credentials.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could also do with the "if needed" restriction.

"If needed" might also be expanded to something like "if requested by the Options" in both cases.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 61c9881c0aac68b401d2efd0893e8c603cbd7ac9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) December 9, 2022 18:15
@coryan coryan merged commit 7142fe5 into googleapis:main Dec 9, 2022
@coryan coryan deleted the feat-common-support-logging-for-credentials branch December 9, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use decorators to implement credential caching and logging Add logging to the credential refresh RPCs
3 participants