feat(common): options for Make*Credentials()
#10417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes all the `g::c::Credential` factory functions to accept a `g::c::Options` parameter. At this time this can be used to initialize logging in the credential layer, but eventually it could gain
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.85% // Head: 93.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10417 +/- ##
==========================================
- Coverage 93.85% 93.85% -0.01%
==========================================
Files 1610 1610
Lines 145821 145822 +1
==========================================
Hits 136866 136866
- Misses 8955 8956 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
devbww
approved these changes
Dec 9, 2022
google/cloud/credentials.h
Outdated
| @@ -82,8 +83,12 @@ struct UnifiedCredentialsOption { | |||
| * and sometimes even errors. | |||
| * | |||
| * @ingroup guac | |||
| * | |||
| * @param opts optional configuration values. Note that the effect of these | |||
| * parameters depends on the underlying transport. For example | |||
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all the
g::c::Credentialfactory functions to accept ag::c::Optionsparameter. At this time this can be used to initialize logging in the credential layer, but eventually it could gainThis change is