-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing <cstdint>
includes
#10421
Conversation
/gcbrun |
<cstdint>
includes
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Thanks for the PR! Seems like the robots think you need to sort some headers. The build logs are listed above, but they are tricky to find, so here is a direct link: Are you using a particular Linux distro to build with GCC 13? I would like to expand our build matrix to cover this case, and I would also like to avoid installing GCC from source. |
I'm afraid I'm using locally built Applied the following header sorting and force-pushed:
Thank you! |
/gcbrun |
Without the change build fails on this week's `gcc-13` as: In file included from google/cloud/internal/curl_handle.cc:15: google/cloud/internal/curl_handle.h:107:8: error: 'int32_t' in namespace 'std' does not name a type 107 | std::int32_t GetResponseCode(); | ^~~~~~~ `gcc-13` cleaned up `<string>` not to include `<cstdint>` for newer c++ standards. Hence the build failures.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Fixed commit message to match PR (now has |
/gcbrun |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.86% // Head: 93.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10421 +/- ##
==========================================
- Coverage 93.86% 93.86% -0.01%
==========================================
Files 1610 1610
Lines 145830 145830
==========================================
- Hits 136888 136887 -1
- Misses 8942 8943 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks again for the PR |
Without the change build fails on this week's
gcc-13
as:gcc-13
cleaned up<string>
not to include<cstdint>
for newer c++ standards. Hence the build failures.This change is