Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): factory function for external accounts #10465

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 20, 2022

Fixes #5915


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 527b20348176f976fcad2c1802f5c8abb2206219

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 93.87% // Head: 93.88% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (527b203) compared to base (b191e83).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10465   +/-   ##
=======================================
  Coverage   93.87%   93.88%           
=======================================
  Files        1624     1624           
  Lines      147462   147465    +3     
=======================================
+ Hits       138436   138448   +12     
+ Misses       9026     9017    -9     
Impacted Files Coverage Δ
google/cloud/internal/credentials_impl_test.cc 100.00% <ø> (ø)
google/cloud/credentials.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
google/cloud/pubsub/samples/samples.cc 88.00% <0.00%> (+0.14%) ⬆️
...sub/internal/batching_publisher_connection_test.cc 99.62% <0.00%> (+0.18%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.63% <0.00%> (+0.33%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 99.33% <0.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 20, 2022 18:26
@coryan coryan requested a review from a team as a code owner December 20, 2022 18:26
@coryan coryan merged commit 46d3075 into googleapis:main Dec 20, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr32 branch December 20, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support third-party identity
3 participants