Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): link references in service comments #10687

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 28, 2023

Fixes #7664


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 93.75% // Head: 93.75% // No change to project coverage 👍

Coverage data is based on head (8da75a0) compared to base (8da75a0).
Patch has no changes to coverable lines.

❗ Current head 8da75a0 differs from pull request most recent head 3ee403e. Consider uploading reports for the commit 3ee403e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10687   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files        1701     1701           
  Lines      153158   153158           
=======================================
  Hits       143588   143588           
  Misses       9570     9570           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review January 28, 2023 17:48
@coryan coryan requested a review from a team as a code owner January 28, 2023 17:48
@coryan coryan merged commit d224e91 into googleapis:main Jan 28, 2023
@coryan coryan deleted the feat-generator-resolve-references-in-service-comments branch January 28, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator doxygen comments include broken links
2 participants