feat: avoid development dependencies with Bazel #11724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolduc
approved these changes
May 24, 2023
bazel/google_cloud_cpp_deps.bzl
Outdated
| @@ -17,8 +17,63 @@ | |||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | |||
| load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe") | |||
|
|
|||
| def google_cloud_cpp_development_deps(name = None): | |||
| """Loads dependencies need to develop the google-cloud-cpp libraries. | |||
bazel/google_cloud_cpp_deps.bzl
Outdated
|
|
||
| google-cloud-cpp developers call this function from the top-level WORKSPACE | ||
| file to obtain all the necessary *development* dependencies for | ||
| google-cloud-cpp, this includes testing dependencies and dependencies used |
bazel/google_cloud_cpp_deps.bzl
Outdated
| google-cloud-cpp, this includes testing dependencies and dependencies used | ||
| by development tools. | ||
|
|
||
| While primarily intended for google-cloud-cpp developers |
bazel/google_cloud_cpp_deps.bzl
Outdated
| @@ -66,7 +121,8 @@ def google_cloud_cpp_deps(name = None): | |||
| strip_prefix = "abseil-cpp-20230125.3", | |||
| ) | |||
|
|
|||
| # Load a version of googletest that we know works. | |||
| # Load a version of googletest that we know works. This is needed to create | |||
| # google_cloud_cpp_*_mocks libraries. | |||
There was a problem hiding this comment.
nit: //:*_mocks instead of google_cloud_cpp_*_mocks ?
(and we just pretend that //:mocks matches the regex)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11724 +/- ##
=======================================
Coverage ? 93.78%
=======================================
Files ? 1829
Lines ? 164882
Branches ? 0
=======================================
Hits ? 154631
Misses ? 10251
Partials ? 0 ☔ View full report in Codecov by Sentry. |
devbww
added a commit
to devbww/google-cloud-cpp
that referenced
this pull request
Jul 5, 2023
Adapt to the new shape of google_cloud_cpp_deps.bzl, where googleapis#11724 introduced an additional `maybe()` calling function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is