-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): increase backoff from 1.3 to 4.0 #12306
fix(pubsub): increase backoff from 1.3 to 4.0 #12306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a feat
. Maybe it is a fix
? Although I have no idea what we are fixing...
Maybe put the motivation for this change in the PR description?
Discussed with Darren. Closing since the motivating change is due to how the GAPIC libraries implement exponential backoff. C++ does not use that implementation. |
Re-opening, the pub/sub team will create an issue motivating the change |
1aa791b
to
a14e8fa
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12306 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 2026 2026
Lines 179055 179055
=======================================
+ Hits 167578 167581 +3
+ Misses 11477 11474 -3
☔ View full report in Codecov by Sentry. |
a14e8fa
to
172501e
Compare
Fixes #12328
This change is