Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gRPC auth logging enabled by "auth" #12702

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Sep 22, 2023

Look for "auth" or "rpc" to enable logging in the minimal IAM credentials stub.


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal September 22, 2023 16:58 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3d4244d) 93.57% compared to head (c4d858a) 93.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12702   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files        2072     2072           
  Lines      183517   183532   +15     
=======================================
+ Hits       171729   171748   +19     
+ Misses      11788    11784    -4     
Files Coverage Δ
...gle/cloud/internal/minimal_iam_credentials_stub.cc 95.91% <100.00%> (+0.04%) ⬆️
...loud/internal/minimal_iam_credentials_stub_test.cc 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc temporarily deployed to internal September 22, 2023 17:44 — with GitHub Actions Inactive
@dbolduc dbolduc temporarily deployed to internal September 22, 2023 18:01 — with GitHub Actions Inactive
@dbolduc dbolduc temporarily deployed to internal September 26, 2023 03:57 — with GitHub Actions Inactive
@dbolduc dbolduc marked this pull request as ready for review September 26, 2023 06:41
@dbolduc dbolduc requested a review from a team as a code owner September 26, 2023 06:41
@dbolduc dbolduc merged commit 3859905 into googleapis:main Sep 26, 2023
54 checks passed
@dbolduc dbolduc deleted the minimal-iam-logging branch September 26, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants